fix: Add user agent for wasm-pack version check #658

drager · 2019-05-25T21:14:07Z

This PR adds a user agent header for the wasm-pack version check. It will look like this: User-Agent: wasm-pack/0.8.1 (https://github.com/rustwasm/wasm-pack).

Fixes #651.

fitzgen

Great! Thanks @drager :)

fitzgen · 2019-06-03T17:22:16Z

It seems like CI has been failing for all the PRs recently and seems sort of related to binary-install. I saw some github emails in that repo, but haven't dug in yet. Do you happen to know what's up?

drager · 2019-06-04T14:40:51Z

@fitzgen Hmm, I haven't really dug in the latest changes for binary-install just yet. Maybe @ashleygwilliams have an idea?

This is the test that fails though:

wasm-pack/tests/all/build.rs

Lines 24 to 69 in b07ec95

    
           fn it_should_build_crates_in_a_workspace() { 
        
               let fixture = utils::fixture::Fixture::new(); 
        
               fixture 
        
                   .file( 
        
                       "Cargo.toml", 
        
                       r#" 
        
                           [workspace] 
        
                           members = ["blah"] 
        
                       "#, 
        
                   ) 
        
                   .file( 
        
                       Path::new("blah").join("Cargo.toml"), 
        
                       r#" 
        
                           [package] 
        
                           authors = ["The wasm-pack developers"] 
        
                           description = "so awesome rust+wasm package" 
        
                           license = "WTFPL" 
        
                           name = "blah" 
        
                           repository = "https://github.com/rustwasm/wasm-pack.git" 
        
                           version = "0.1.0" 
        
                           [lib] 
        
                           crate-type = ["cdylib"] 
        
                           [dependencies] 
        
                           wasm-bindgen = "0.2" 
        
                       "#, 
        
                   ) 
        
                   .file( 
        
                       Path::new("blah").join("src").join("lib.rs"), 
        
                       r#" 
        
                           extern crate wasm_bindgen; 
        
                           use wasm_bindgen::prelude::*; 
        
                           #[wasm_bindgen] 
        
                           pub fn hello() -> u32 { 42 } 
        
                       "#, 
        
                   ) 
        
                   .install_local_wasm_bindgen(); 
        
               fixture 
        
                   .wasm_pack() 
        
                   .current_dir(&fixture.path.join("blah")) 
        
                   .arg("build") 
        
                   .assert() 
        
                   .success(); 
        
           }

ashleygwilliams · 2019-06-11T09:16:08Z

merging as this change is not related to the CI failure

fix: Add user agent for wasm-pack version check

bd3dec1

drager force-pushed the add-user-agent branch from 96609d2 to bd3dec1 Compare May 27, 2019 19:32

drager requested review from ashleygwilliams and fitzgen May 27, 2019 19:33

fitzgen approved these changes Jun 3, 2019

View reviewed changes

ashleygwilliams approved these changes Jun 4, 2019

View reviewed changes

ashleygwilliams approved these changes Jun 11, 2019

View reviewed changes

ashleygwilliams added this to the 0.9.0 milestone Jun 11, 2019

ashleygwilliams added the changelog - maintenance label Jun 11, 2019

ashleygwilliams merged commit 95a4e30 into rustwasm:master Jun 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add user agent for wasm-pack version check #658

fix: Add user agent for wasm-pack version check #658

drager commented May 25, 2019

fitzgen left a comment

fitzgen commented Jun 3, 2019

drager commented Jun 4, 2019

ashleygwilliams commented Jun 11, 2019

fix: Add user agent for wasm-pack version check #658

fix: Add user agent for wasm-pack version check #658

Conversation

drager commented May 25, 2019

fitzgen left a comment

Choose a reason for hiding this comment

fitzgen commented Jun 3, 2019

drager commented Jun 4, 2019

ashleygwilliams commented Jun 11, 2019